Skip to content

pass generator instead of seed to diffusers #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

ErikKaum
Copy link
Member

@ErikKaum ErikKaum commented Oct 7, 2024

  • is seed is passed in
  • "convert" to generator which is supported in diffusers
  • follows the same logic as in the inference API

Background context: https://huggingface.slack.com/archives/C03E4DQ9LAJ/p1728293731737859

@ErikKaum ErikKaum requested a review from philschmid October 7, 2024 15:10
Copy link
Contributor

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ErikKaum ErikKaum merged commit 7fe090c into main Oct 7, 2024
6 checks passed
@ErikKaum ErikKaum deleted the fix/seed-generator-for-diffusers branch October 7, 2024 15:16
Copy link

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@@ -47,6 +47,13 @@ def __call__(
prompt,
**kwargs,
):
# diffusers doesn't support seed but rather the generator kwarg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@ErikKaum ErikKaum Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah lol, I just merged and after that this comment popped up. But I'll add it in a separate PR. I think it's a good idea to have the "paper trace"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants