feat(metrics): add /metrics which returns prometheus metrics #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co42
commented
Oct 23, 2024
co42
force-pushed
the
feat/metrics-concurrent-connection
branch
2 times, most recently
from
8ec058c to
551d454
Compare
co42
commented
Oct 23, 2024
Comment on lines
+79
to
+80
| f"inf_batch_current_size {batch_current_size}\n" + | ||
| f"inf_queue_size {queue_size}\n" |
There was a problem hiding this comment.
Not sure the naming is the best, I copied TGI
There was a problem hiding this comment.
Are we okay that this will always be 1?
There was a problem hiding this comment.
If it bother you or makes it unclear for customers I can remove inf_batch_current_size
alvarobartt
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
LGTM, maybe let's wait and see if @philschmid agrees on the metrics reported and we can merge 🤗 Thanks!
co42
force-pushed
the
feat/metrics-concurrent-connection
branch
from
551d454 to
05868e5
Compare
philschmid
approved these changes
Nov 4, 2024
Comment on lines
+79
to
+80
| f"inf_batch_current_size {batch_current_size}\n" + | ||
| f"inf_queue_size {queue_size}\n" |
There was a problem hiding this comment.
Are we okay that this will always be 1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be useful for Dedicated Endpoints to improve request forwarding fairness and scaling