-
Notifications
You must be signed in to change notification settings - Fork 596
✨ Add apps params to listModels #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Add apps params to listModels #1910
Conversation
|
@Wauplin, when you have some time, could you please take a look at this small item. Also needs workflow approval from maintainers |
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nagesh161007 , thanks for the PR. I've left 2 main comments:
- for
apps, let's add a more robust test - for
library, it's not possible to filter as you did since it's already handled byfilter
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good once comment is addressed. Can you also update the PR title and description to match the new behavior?
And let's wait for @coyotte508 's review before merging
Co-authored-by: Lucain <[email protected]>
What does this PR do?
Adds support for filtering models by
appsparameters in thelistModelsfunction, enabling users to filter models based on supported applicationsChanges
apps?: string[]- Filter models by supported applications (vllm, ollama, tgi, mlx-lm, etc.)Example Usage