[Tasks] Refactor NVIDIA hardware specs with typed compute capabilities#2032
Merged
[Tasks] Refactor NVIDIA hardware specs with typed compute capabilities#2032
Conversation
Extract NVIDIA GPU specs into a standalone `NVIDIA_SKUS` constant with a `NvidiaHardwareSpec` interface that makes `computeCapability` required. Also export the completed `NvidiaComputeCapabilities` enum. Co-Authored-By: Claude <Agents+claude@huggingface.co>
Co-Authored-By: Claude <Agents+claude@huggingface.co>
Move NvidiaHardwareSpec, NvidiaComputeCapabilities, and NVIDIA_SKUS into a dedicated hardware-nvidia.ts file. Re-exported from hardware.ts to keep the public API unchanged. Co-Authored-By: Claude <Agents+claude@huggingface.co>
…-nvidia Co-Authored-By: Claude <Agents+claude@huggingface.co>
Member
Author
|
will merge like this because i think it's nice, but still open for some feedback/objections! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NvidiaComputeCapabilitiesenum with all 15 architectures (Blackwell Ultra through Maxwell)NvidiaHardwareSpec,NvidiaComputeCapabilities, andNVIDIA_SKUSinto a dedicatedhardware-nvidia.tsfileNVIDIA_SKUSasRecord<string, NvidiaHardwareSpec>with requiredcomputeCapabilityTest plan
npx tsc --noEmit)SKUS.GPU.NVIDIAstill work as expectedNote
Medium Risk
Moderate risk due to a public type/API surface change:
computeCapabilityis no longer part of genericHardwareSpec, so downstream TypeScript consumers may need updates even though runtime SKU data is unchanged.Overview
Moves the NVIDIA GPU SKU table out of
hardware.tsinto a newhardware-nvidia.ts, introducingNvidiaHardwareSpec(with requiredcomputeCapability) and a completedNvidiaComputeCapabilitiesenum.Updates
hardware.tsto referenceNVIDIA_SKUSforSKUS.GPU.NVIDIAand removescomputeCapabilityfrom the genericHardwareSpecinterface, and re-exports the new NVIDIA-specific type fromindex.ts.Written by Cursor Bugbot for commit 9c2b8d8. This will update automatically on new commits. Configure here.