Skip to content

[Tasks] Refactor NVIDIA hardware specs with typed compute capabilities#2032

Merged
julien-c merged 5 commits intomainfrom
refactor-nvidia-skus-and-compute-capabilities
Mar 11, 2026
Merged

[Tasks] Refactor NVIDIA hardware specs with typed compute capabilities#2032
julien-c merged 5 commits intomainfrom
refactor-nvidia-skus-and-compute-capabilities

Conversation

@julien-c
Copy link
Member

@julien-c julien-c commented Mar 11, 2026

Summary

  • Complete NvidiaComputeCapabilities enum with all 15 architectures (Blackwell Ultra through Maxwell)
  • Extract NvidiaHardwareSpec, NvidiaComputeCapabilities, and NVIDIA_SKUS into a dedicated hardware-nvidia.ts file
  • Type NVIDIA_SKUS as Record<string, NvidiaHardwareSpec> with required computeCapability

Test plan

  • TypeScript compiles cleanly (npx tsc --noEmit)
  • Verify downstream consumers of SKUS.GPU.NVIDIA still work as expected

Note

Medium Risk
Moderate risk due to a public type/API surface change: computeCapability is no longer part of generic HardwareSpec, so downstream TypeScript consumers may need updates even though runtime SKU data is unchanged.

Overview
Moves the NVIDIA GPU SKU table out of hardware.ts into a new hardware-nvidia.ts, introducing NvidiaHardwareSpec (with required computeCapability) and a completed NvidiaComputeCapabilities enum.

Updates hardware.ts to reference NVIDIA_SKUS for SKUS.GPU.NVIDIA and removes computeCapability from the generic HardwareSpec interface, and re-exports the new NVIDIA-specific type from index.ts.

Written by Cursor Bugbot for commit 9c2b8d8. This will update automatically on new commits. Configure here.

julien-c and others added 4 commits March 11, 2026 15:52
Extract NVIDIA GPU specs into a standalone `NVIDIA_SKUS` constant with a
`NvidiaHardwareSpec` interface that makes `computeCapability` required.
Also export the completed `NvidiaComputeCapabilities` enum.

Co-Authored-By: Claude <Agents+claude@huggingface.co>
Co-Authored-By: Claude <Agents+claude@huggingface.co>
Move NvidiaHardwareSpec, NvidiaComputeCapabilities, and NVIDIA_SKUS
into a dedicated hardware-nvidia.ts file. Re-exported from hardware.ts
to keep the public API unchanged.

Co-Authored-By: Claude <Agents+claude@huggingface.co>
…-nvidia

Co-Authored-By: Claude <Agents+claude@huggingface.co>
@julien-c
Copy link
Member Author

will merge like this because i think it's nice, but still open for some feedback/objections!

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@julien-c julien-c merged commit 07beba2 into main Mar 11, 2026
6 of 7 checks passed
@julien-c julien-c deleted the refactor-nvidia-skus-and-compute-capabilities branch March 11, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant