[Tasks] Add Apple M5 Pro and M5 Max to hardware specs#2033
[Tasks] Add Apple M5 Pro and M5 Max to hardware specs#2033
Conversation
Add Apple M5 Pro (20-core GPU, up to 64GB) and M5 Max (40-core GPU, up to 128GB) to the hardware SKU definitions, following the same scaling pattern as M4 Pro/Max. Co-Authored-By: Claude <Agents+claude@huggingface.co>
julien-c
requested review from
SBrandeis,
Wauplin,
gary149,
ngxson and
pcuenca
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| }, | ||
| "Apple M5 Pro": { | ||
| tflops: 11.4, | ||
| memory: [24, 36, 48, 64], |
There was a problem hiding this comment.
M5 Pro memory includes nonexistent 36GB configuration
Medium Severity
The memory array for "Apple M5 Pro" includes 36 GB, but Apple's official specs list only 24GB, 48GB, and 64GB configurations for the M5 Pro. The 36GB option exists for the M5 Max (and M4 Max) but not for the Pro tier. This matches the M4 Pro pattern which also has [24, 48, 64] without 36GB. The array here likely needs the 36 removed.
|
tests are a bit flaky for some reason @mishig25 |
yea needs deep investigation or claude code on the case, possibly cache issues idk - anyway not relevant for this PR |
3 participants
Summary
Sources
Test plan
Note
Low Risk
Adds static data entries to the hardware spec map with no behavioral or control-flow changes; main risk is incorrect spec values affecting sizing results.
Overview
Updates the
SKUShardware definitions to include new Apple Silicon entries forApple M5 ProandApple M5 Max.Each new SKU adds TFLOPS values and supported unified memory configurations so downstream sizing/threshold logic can recognize these chips.
Written by Cursor Bugbot for commit da45621. This will update automatically on new commits. Configure here.