Skip to content

feat: pass pre-computed SHA-256 to hf_xet upload #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wauplin merged 7 commits into from
Mar 13, 2026
Merged

feat: pass pre-computed SHA-256 to hf_xet upload #3876

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ac84d1
Pass pre-computed SHA-256 to hf_xet upload for repo commits
XciD Mar 3, 2026
a791356
Assert sha256s kwarg in test_request_headers_passed_to_upload_files
XciD Mar 3, 2026
a50b56c
Pass pre-computed SHA-256 to hf_xet upload_bytes for repo commits
XciD Mar 3, 2026
a344ec6
Merge branch 'main' into feat/pass-sha256-to-xet
Wauplin Mar 12, 2026
710e45b
bump minimal version
Wauplin Mar 12, 2026
888b41c
Merge branch 'main' into feat/pass-sha256-to-xet
Wauplin Mar 13, 2026
d799e2d
hf-xet 1.4.2
Wauplin Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/huggingface_hub/_commit_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,7 @@ def token_refresher() -> tuple[str, int]:

if len(all_paths_ops) > 0:
all_paths = [str(op.path_or_fileobj) for op in all_paths_ops]
all_sha256s = [op.upload_info.sha256.hex() for op in all_paths_ops]
upload_files(
all_paths,
xet_endpoint,
Expand All @@ -649,10 +650,12 @@ def token_refresher() -> tuple[str, int]:
progress_callback,
repo_type,
request_headers=xet_headers,
sha256s=all_sha256s,
)

if len(all_bytes_ops) > 0:
all_bytes = [op.path_or_fileobj for op in all_bytes_ops]
all_sha256s = [op.upload_info.sha256.hex() for op in all_bytes_ops]
upload_bytes(
all_bytes,
xet_endpoint,
Expand All @@ -661,6 +664,7 @@ def token_refresher() -> tuple[str, int]:
progress_callback,
repo_type,
request_headers=xet_headers,
sha256s=all_sha256s,
)

finally:
Expand Down
2 changes: 2 additions & 0 deletions tests/test_xet_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ def test_request_headers_passed_to_upload_files(self, tmp_path):
assert request_headers.get("x-custom-header") == "custom_value"
assert request_headers.get("user-agent") == "test-agent"
assert "authorization" not in request_headers
assert mock_upload_files.call_args.kwargs["sha256s"] == [addition.upload_info.sha256.hex()]

def test_request_headers_passed_to_upload_bytes(self):
"""Test that headers (minus authorization) are passed as request_headers to hf_xet.upload_bytes."""
Expand Down Expand Up @@ -289,6 +290,7 @@ def test_request_headers_passed_to_upload_bytes(self):
assert request_headers.get("x-custom-header") == "custom_value"
assert request_headers.get("user-agent") == "test-agent"
assert "authorization" not in request_headers
assert mock_upload_bytes.call_args.kwargs["sha256s"] == [addition.upload_info.sha256.hex()]

def test_upload_folder(self, api, repo_url):
repo_id = repo_url.repo_id
Expand Down
Loading