Prefer ruff formatting#462
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I think the failing test is unrelated and introduced in #467? |
| kernels | ||
| with: | ||
| src: kernels | ||
| version: "0.15.10" |
There was a problem hiding this comment.
Do we always want to run with latest ruff?
There was a problem hiding this comment.
I think pinning the ruff version is not a bad idea, since there will be subtle formatting differences between versions and then if CI uses the latest and a local venv or Nix env uses a different version, then there will always be mismatches.
| black: | ||
| name: Run black check | ||
| griffe: | ||
| name: Check API compatibility |
There was a problem hiding this comment.
Ou jazzy. I didn't know this!
| # "E501" -> line length violation | ||
| lint.ignore = ["E501"] | ||
| lint.select = ["E", "F", "W"] | ||
| lint.select = ["E", "F", "I", "W"] |
There was a problem hiding this comment.
Do we want to also instruct ruff to take care of sorting the imports, remove unused imports, etc. if not already done?
There was a problem hiding this comment.
It looks like I enables import formatting, resorting, and it is run as part of linting:
Since we are running ruff check --fix, it should be good I think.
4 participants
this pr update the repo to prefer using
ruffformatting overblackandisort. additionally it addsgriffeto add a check for any breaking changes to public functions