Skip to content

fix(utils): preserve keys for numpy array values in flatten_dict #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cupkk wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

fix(utils): preserve keys for numpy array values in flatten_dict #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lighteval/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def rec(nest: dict, prefix: str, into: dict):
) # Need this for markdown
into[prefix + k + sep + str(i)] = vv.tolist() if isinstance(vv, np.ndarray) else vv
elif isinstance(v, np.ndarray):
into[prefix + k + sep + str(i)] = v.tolist()
into[prefix + k] = v.tolist()
else:
v = clean_markdown(v)
into[prefix + k] = v
Expand Down
16 changes: 15 additions & 1 deletion tests/unit/utils/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,21 @@

import unittest

from lighteval.utils.utils import remove_reasoning_tags
import numpy as np

from lighteval.utils.utils import flatten_dict, remove_reasoning_tags


class TestFlattenDict(unittest.TestCase):
def test_numpy_array_value(self):
result = flatten_dict({"scores": np.array([1, 2])})

self.assertEqual(result, {"scores": [1, 2]})

def test_numpy_array_value_does_not_reuse_list_index(self):
result = flatten_dict({"items": ["a", "b"], "scores": np.array([1, 2])})

self.assertEqual(result, {"items/0": "a", "items/1": "b", "scores": [1, 2]})


class TestRemoveReasoningTags(unittest.TestCase):
Expand Down