Fix caching logic - #994
Open
jxmorris12 wants to merge 5 commits into
Open
Conversation
Member
|
Hi! Thanks for the PR - for viz, the team is at a conference, but I'll take a look next Mon, feel free to ping me then if needed! |
Collaborator
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Can you fix the tests before I take a look? |
Author
|
should be fixed! |
clefourrier
reviewed
Oct 6, 2025
Comment on lines
+166
to
+169
| task_suite, task_name, few_shot = full_task_name.split("|") | ||
| task_configs: list[LightevalTaskConfig] = sorted( | ||
| self.registry.task_to_configs[f"{task_suite}|{task_name}|{few_shot}"] | ||
| ) |
Member
There was a problem hiding this comment.
might as well use the full task name then ^^
| ) | ||
|
|
||
| task_to_configs[expanded_task].append(config) | ||
| task_to_configs[expanded_task + f"|{few_shot}"].append(config) |
Member
There was a problem hiding this comment.
you'll likely need to update the logic throughout to use the full task name with few shots in all the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the code throws an error if you try to evaluate the same dataset with different numbers of shots. My PR fixes that.