Adding a script to test accuracy on IPU provider after quantization with Quark#148
Open
hanlin0628 wants to merge 18 commits intohuggingface:mainfrom
Open
Adding a script to test accuracy on IPU provider after quantization with Quark#148hanlin0628 wants to merge 18 commits intohuggingface:mainfrom
hanlin0628 wants to merge 18 commits intohuggingface:mainfrom
Conversation
Contributor
|
Hi @hanlin0628, I have been working on integrating the Quark quantizer into
If the interfaces are similar, I would like to discuss how we can better integrate them into a single |
Author
|
Hi Mohit
The code of vai_q_onnx quantiser has been merged into Quark, so the Quark
now has two quantisers, quark.torch and quark.onnx.
Regards,
Han
…On Fri, Jul 26, 2024 at 2:10 PM Mohit Sharma ***@***.***> wrote:
Hi @hanlin0628 <https://github.com/hanlin0628>,
I have been working on integrating the Quark quantizer into optimum-amd
through this pull request: #149
<#149>. I noticed a few
things and would like to clarify the following:
-
Is the vaiq_onnx quantiser deprecated?
-
The Quark quantiser used in this PR appears to be different from the
Quark torch quantizer and seems to be ONNX-based (as per Quark
documentation
<https://quark.docs.amd.com/latest/quark_torch_main_gen.html>). Do we
have two different sources for the Quark quantiser?
If the interfaces are similar, I would like to discuss how we can better
integrate them into a single OptimumQuantizer.
—
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2TU6WBCDVF6HV7BUHERLLZOHR55AVCNFSM6AAAAABK7UVANSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJSGA2DGNBVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Han Lin
|
Author
|
Hi Mohit @mht-sharma Could you please review the recent update and help me to merge? Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.