Open
Conversation
Contributor
|
Shall we hide the export phase in a function? |
Contributor
Author
|
@Giuseppe5 yes it would be good indeed. |
Contributor
|
The possibility to exclude Q nodes from export it's supported only for Pytorch 2.2+, and I suspect that it is because of this PR: For now, I would add a constraints to use PyTorch > 2.2+. In parallel, it could be worth exploring if we can control what is a initializer and what is a parameter when exporting a graph from pytorch to onnx. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title.