Skip to content

[DO NOT LAND] Add linear+bias decomposition #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuelcandales wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DO NOT LAND] Add linear+bias decomposition #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions optimum/exporters/executorch/recipes/metal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
METAL_BACKEND_AVAILABLE = False

if METAL_BACKEND_AVAILABLE:
import torch

from tabulate import tabulate
from torch.export import ExportedProgram

Expand All @@ -52,6 +54,13 @@
)
from ..recipe_registry import register_recipe

def _linear_bias_decomposition(input, weight, bias=None):
weight_t = torch.ops.aten.t.default(weight)
out = torch.ops.aten.matmul.default(input, weight_t)
if bias is not None:
return torch.ops.aten.add.Tensor(out, bias)
return out

@register_recipe("metal")
def export_to_executorch_with_metal(
model: Union[
Expand Down Expand Up @@ -89,6 +98,13 @@ def _lower_to_executorch(
if len(exported_programs) == 1:
exported_programs = {"forward": next(iter(exported_programs.values()))}

# Decompose linear+bias into matmul+add to avoid addmm,
# which the Metal backend doesn't support.
for key in exported_programs:
decomp_table = torch.export.default_decompositions()
decomp_table[torch.ops.aten.linear.default] = _linear_bias_decomposition
exported_programs[key] = exported_programs[key].run_decompositions(decomp_table)

partitioners = {
key: [MetalPartitioner([MetalBackend.generate_method_name_compile_spec(key)])]
for key in exported_programs.keys()
Expand Down