Skip to content

Conversation

openvino-dev-samples
Copy link
Contributor

@openvino-dev-samples openvino-dev-samples commented Aug 7, 2025

@openvino-dev-samples openvino-dev-samples changed the title add support for minicpm4v [OpenVINO]add support for minicpm4v Aug 7, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@openvino-dev-samples
Copy link
Contributor Author

openvino-dev-samples commented Aug 8, 2025

@IlyasMoutawwakil could help to take a look ?

@IlyasMoutawwakil
Copy link
Member

Thanks for the fix ! let's create a tiny random model with llama as the decoder to test this 🤗 tell me you need help with that !

@openvino-dev-samples
Copy link
Contributor Author

Thanks for the fix ! let's create a tiny random model with llama as the decoder to test this 🤗 tell me you need help with that !

But i guess we need merge this PR first ? otherwise test case will not work

@IlyasMoutawwakil
Copy link
Member

@openvino-dev-samples no need to merge it now, you can simply pin that PR in setup.py so that the tests would run with it 🤗
We will merge both PRs once everything works together.

@openvino-dev-samples
Copy link
Contributor Author

@openvino-dev-samples no need to merge it now, you can simply pin that PR in setup.py so that the tests would run with it 🤗 We will merge both PRs once everything works together.

Hi since minicpmv4 and minicpmv share a same model type, but different LLM. It is possible to add both of them in utils_tests.py ?

@IlyasMoutawwakil
Copy link
Member

@openvino-dev-samples yes, you can name it minicpmv4 in utils_tests.py

@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented Aug 18, 2025

Hi @openvino-dev-samples it would be faster if you made sure the minicpmv4 tests pass locally, the ci is slow and shouldn't be used as a testing mechanism, only use it for validating when local tests are already passing.

@openvino-dev-samples
Copy link
Contributor Author

Hi @openvino-dev-samples it would be faster if you made sure the minicpmv4 tests pass locally, the ci is slow and shouldn't be used as a testing mechanism, only use it for validating when local tests are already passing.

Sorry for that, and i fully understand, but i always met connection issue in local test case, e.g

huggingface_hub.errors.HfHubHTTPError: 429 Client Error: Too Many Requests for url: https://huggingface.co/api/models/katuni4ka/tiny-random-qwen2.5-vl/tree/main?recursive=True&expand=False

@IlyasMoutawwakil
Copy link
Member

but i always met connection issue in local test case

you can target minicpmv tests specifically to avoid this issue with pytest -k "minicpmv"

@openvino-dev-samples openvino-dev-samples changed the title [OpenVINO]add support for minicpm4v [OpenVINO]add support for minicpmv4/4_5 Aug 27, 2025
"minicpm3": "katuni4ka/tiny-random-minicpm3",
"minicpmv": "katuni4ka/tiny-random-minicpmv-2_6",
"minicpmv4": "snake7gun/minicpm-v-4-tiny",
"minicpmv4_5": "snake7gun/tiny-minicpmv-4_5",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

158M model size, it makes sense to try to reduce the size

Copy link
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests for inference to test generate() method and compare with transformers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants