-
Notifications
You must be signed in to change notification settings - Fork 146
[OpenVINO]add support for minicpmv4/4_5 #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[OpenVINO]add support for minicpmv4/4_5 #1412
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@IlyasMoutawwakil could help to take a look ? |
Thanks for the fix ! let's create a tiny random model with llama as the decoder to test this 🤗 tell me you need help with that ! |
But i guess we need merge this PR first ? otherwise test case will not work |
@openvino-dev-samples no need to merge it now, you can simply pin that PR in setup.py so that the tests would run with it 🤗 |
Hi since minicpmv4 and minicpmv share a same model type, but different LLM. It is possible to add both of them in utils_tests.py ? |
@openvino-dev-samples yes, you can name it minicpmv4 in utils_tests.py |
Hi @openvino-dev-samples it would be faster if you made sure the minicpmv4 tests pass locally, the ci is slow and shouldn't be used as a testing mechanism, only use it for validating when local tests are already passing. |
Sorry for that, and i fully understand, but i always met connection issue in local test case, e.g
|
you can target minicpmv tests specifically to avoid this issue with pytest -k "minicpmv" |
tests/openvino/utils_tests.py
Outdated
"minicpm3": "katuni4ka/tiny-random-minicpm3", | ||
"minicpmv": "katuni4ka/tiny-random-minicpmv-2_6", | ||
"minicpmv4": "snake7gun/minicpm-v-4-tiny", | ||
"minicpmv4_5": "snake7gun/tiny-minicpmv-4_5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
158M model size, it makes sense to try to reduce the size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add tests for inference to test generate()
method and compare with transformers
Depends on PR
As LLM of minicpmv4 switched to Llama
https://huggingface.co/openbmb/MiniCPM-V-4/blob/main/modeling_minicpmv.py#L26