Skip to content

[OpenVINO] Accept nncf dev 2.19.0 builds #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wkobielx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[OpenVINO] Accept nncf dev 2.19.0 builds #1550

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3f4beb
Accept dev 2.19 builds
wkobielx Dec 11, 2025
32bcffe
Update exception message
wkobielx Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions optimum/intel/openvino/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@
logging.disable(logging.INFO)
import nncf

if is_nncf_version("<", "2.19"):
if not is_nncf_version(">=", "2.19.0.dev0"):
Copy link
Collaborator

@rkazants rkazants Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just cut off the current version value to have in format xx.yy.zz and after that we can do comparation like is_nncf_version("<", "2.19"). It should fix the problem

Copy link
Contributor

@nikita-savelyevv nikita-savelyevv Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! Unfortunately that won't work because in NNCF we increase dev version to the next one right after the release, i.e. the version was updated to 2.19.0.dev0 back in August openvinotoolkit/nncf@5ba2f29. That's why we'll have the same problem as described in #1550 (review).

raise ImportError(
"NNCF version 2.19 or higher is required to use NNCF-based quantization. "
"NNCF version 2.19.0.dev0 or higher is required to use NNCF-based quantization. "
f"Please upgrade your NNCF installation. The current version of NNCF is {nncf.__version__}."
)

Expand Down
Loading