Skip to content

Conversation

@nikita-savelyevv
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv commented Dec 12, 2025

What does this PR do?

Revert NNCF version check to be a warning until a proper solution is found.

The current problem is that when NNCF is manually installed from the release branch, i.e. pip install git+https://github.com/openvinotoolkit/nncf.git@release_v2190, the version becomes 2.19.0.dev0+8a9d5871e and it does not pass the condition. We also can't truncate the version because it will allow installing from any intermediate commit between NNCF 2.18 and 2.19 (in NNCF we raise version on the develop branch to the next one right after the release).

One solution is to do if is_nncf_version("<", "2.19") and not is_nncf_version("==", "2.19.0.dev0+8a9d5871e"):, but it looks hacky. Perhaps, we'll make changes on NNCF side to improve on this.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@nikita-savelyevv nikita-savelyevv changed the title Revert NNCF version check [OpenVINO] Revert NNCF version check Dec 12, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix echarlaix merged commit b58a715 into main Dec 15, 2025
24 of 28 checks passed
@echarlaix echarlaix deleted the ns/revert-nncf-version-check branch December 15, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants