[OpenVINO] Revert NNCF version check #1554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Revert NNCF version check to be a warning until a proper solution is found.
The current problem is that when NNCF is manually installed from the release branch, i.e.
pip install git+https://github.com/openvinotoolkit/nncf.git@release_v2190, the version becomes2.19.0.dev0+8a9d5871eand it does not pass the condition. We also can't truncate the version because it will allow installing from any intermediate commit between NNCF 2.18 and 2.19 (in NNCF we raise version on the develop branch to the next one right after the release).One solution is to do
if is_nncf_version("<", "2.19") and not is_nncf_version("==", "2.19.0.dev0+8a9d5871e"):, but it looks hacky. Perhaps, we'll make changes on NNCF side to improve on this.Before submitting