fix: do not require packaging for Torch 2.3.0+ datatype support#705
Open
akx wants to merge 1 commit intohuggingface:mainfrom
Open
fix: do not require packaging for Torch 2.3.0+ datatype support#705akx wants to merge 1 commit intohuggingface:mainfrom
packaging for Torch 2.3.0+ datatype support#705akx wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR drops the dependency on
packaging; looking at whethertorch.uint64exists is enough of a canary to see whether Torch 2.3.0 is in use and the new uint types are there.Beyond the unnecessary dependency, this is also faster and that's not counting the import time for
packaging...Follows up on #664, #643.