fix(executor): reject oversized integer results before ** / << / *#2512
Open
axelray-dev wants to merge 1 commit into
Open
fix(executor): reject oversized integer results before ** / << / *#2512axelray-dev wants to merge 1 commit into
axelray-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2473.
The local Python executor could still freeze on a single oversized integer operation (
**,<<, large*) because thread-based timeouts cannot interrupt CPython integer work under the GIL.MAX_OPERATIONSdoes not help for one AST node.This change estimates result bit length before those operations and raises
InterpreterErrorwhen the estimate exceedsMAX_INT_RESULT_BITS(10_000_000).Changes
MAX_INT_RESULT_BITSnext to the existing executor limits**,<<, and large*inevaluate_binopVerification
pytest tests/test_local_python_executor.py -q(403 passed, 2 skipped)Backwards compatibility
Normal small integer arithmetic is unchanged. Only results estimated above the bit-length cap are rejected early.