Conversation
pcuenca
reviewed
Jul 30, 2025
pcuenca
left a comment
pcuenca
left a comment
Member
There was a problem hiding this comment.
Amazing work!
Why did it trigger so many format changes? We've had several PRs added after swift format was introduced.
Contributor
Author
|
|
Contributor
Author
|
429 in CI for tests. |
Member
|
Tests pass locally. How do you feel about merging the two pending PRs while we deal with the CI, @FL33TW00D? |
Contributor
Author
|
@pcuenca happy to do it! Will merge the pinning first, then fix this branch and merge it |
Member
|
Awesome! I opened huggingface/hf-workflows#38 to try to fix the CI 🤞 |
Member
|
Merging anyway. |
Contributor
Author
|
Sorry @pcuenca missed this, thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation #210 (comment)