updated applyChatTemplate with lazy memoization - #218
Merged
Conversation
Contributor
|
@tpae great contribution thank you. If you could format it with the pinned version of
|
Contributor
Author
|
Amazing! Thank you! My brew couldn't find |
Contributor
Author
|
Test was passing for me locally 🤔 i think 429 is rate limiting |
Member
|
Tests pass for me locally as well, and the CI worked for this PR too. So I think the token may not be passed to the CI from forks. I'll take a quick look, otherwise I'll merge and resolve later. |
Member
|
I'm merging. Also opened #222 which could be interesting for actual use cases, not just the CI. |
Member
|
Thanks a lot @tpae! |
This was referenced Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #217.
Cache compiled Jinja Template instances in PreTrainedTokenizer keyed by the template string; reuse in applyChatTemplate. No API or behavior changes.
Measured performance: Repeated calls with the same template are ~6x faster.
Cached (reused template): ~0.00049 s (0.49 ms) average
Uncached (unique template each call): ~0.00292 s (2.92 ms) average
Speedup: ~5.9–6.2x
Raw results: