Skip to content

Change Trie access level to internal (implicitly) - #243

Merged
mattt merged 1 commit into
mainfrom
mattt/non-public-trie
Sep 17, 2025
Merged

Change Trie access level to internal (implicitly)#243
mattt merged 1 commit into
mainfrom
mattt/non-public-trie

Conversation

@mattt

@mattt mattt commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

Trie is a custom collection type used by UnigramTokenizer. Since it's used only by that component as an implementation detail, we can reduce the surface area of the public API by making this internal.

@mattt
mattt requested a review from pcuenca September 17, 2025 13:32

@pcuenca pcuenca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, agreed

@pcuenca pcuenca added the v1.0 label Sep 17, 2025
@mattt
mattt merged commit 07f32d9 into main Sep 17, 2025
2 checks passed
@mattt
mattt deleted the mattt/non-public-trie branch September 17, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants