Add Sendable conformance to Hub.Repo and Hub.RepoType - #374
Merged
Conversation
Both are immutable Codable value types but do not conform to Sendable, which under Swift 6 / strict concurrency prevents passing them across actor or task boundaries (e.g. a Repo captured in a Task or stored in an actor-isolated cache). Both are trivially sendable: RepoType is a String-raw enum and Repo has only let properties of Sendable types (String, RepoType). No behavior change.
rcfa
marked this pull request as ready for review
June 27, 2026 06:19
pcuenca
approved these changes
Jun 28, 2026
Member
|
Thanks @rcfa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hub.RepoTypeandHub.Repoare immutableCodablevalue types but don't conform toSendable. Under Swift 6 / strict concurrency that prevents passing them across actor or taskboundaries (e.g. a
Repocaptured in aTask, or stored in an actor-isolated cache) withoutwarnings or errors.
Both are trivially sendable:
RepoTypeis aString-rawenum.Repohas onlyletproperties ofSendabletypes (String,RepoType).This adds the conformance. Additive (no API break), no behavior change.