changed the encode method and added overloads #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenova
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Nice! This looks good to me.
It might also be good to see how the rust library handles or delegates padding/truncation of batched inputs to the python library, since we might need to move this to transformers.js
e.g., there is encode_batch (https://huggingface.co/docs/tokenizers/api/encode-inputs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compared our implementation with https://huggingface.co/docs/tokenizers/quicktour and it seems like they return not only the token_ids, but also the attention_mask and the tokens.
I think we should adapt it so that our solution is the same as the Python implementation.
I also added function overloads for the return_token_type_ids so we have more percise return types based on the config.