Reject a zero length in the FixedLength pre-tokenizer instead of panicking#2155
Open
v-code01 wants to merge 1 commit into
Open
Reject a zero length in the FixedLength pre-tokenizer instead of panicking#2155v-code01 wants to merge 1 commit into
v-code01 wants to merge 1 commit into
Conversation
…cking `FixedLength::length` is deserialized from the config with no validation (`FixedLength::new` performs none either). A value of 0 reaches `char_positions.chunks(self.length)`, which panics with "chunk size must be non-zero" on any non-empty input — a crafted `tokenizer.json` crashes tokenization. Reject `length == 0` with a clear error at the start of `pre_tokenize`. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FixedLength::lengthis deserialized from the config with no validation (FixedLength::newperforms none either). A value of0reaches:so a crafted
{"type":"FixedLength","length":0}pre-tokenizer crashes tokenization on any non-empty input.Fix
Reject
length == 0with a clear error at the start ofpre_tokenize:Tests
Adds
zero_length_is_rejected; existingFixedLengthtests are unchanged.cc @ArthurZucker @McPatate