Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker: move prepare_inputs_for_generation into the generation mixin 🧹 #32685

Open
3 of 8 tasks
gante opened this issue Aug 14, 2024 · 2 comments
Open
3 of 8 tasks
Assignees
Labels
Generation WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress

Comments

@gante
Copy link
Member

gante commented Aug 14, 2024

🧹 This is a tracker regarding the move of prepare_inputs_for_generation into the generation mixin 🧹

Why?

  1. prepare_inputs_for_generation is not part of the core modeling, but rather a utility for generate
  2. it should greatly reduce the need to touch modeling code, on generate changes. Fewer modeling changes -> improved model stability
  3. greatly reduced number of lines of code 🙏

Tracker

Kinda ordered list of tasks:

@gante gante self-assigned this Aug 14, 2024
@gante
Copy link
Member Author

gante commented Aug 14, 2024

@ydshieh edit the tracker above as soon as you start working on a task, so we don't risk doing redundant work 🤗 (e.g. with the link to a draft PR)

I'll do the same!

@ydshieh ydshieh self-assigned this Aug 14, 2024
@ydshieh
Copy link
Collaborator

ydshieh commented Aug 14, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Generation WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Projects
None yet
Development

No branches or pull requests

2 participants