-
Notifications
You must be signed in to change notification settings - Fork 31.4k
Add .on_push_begin() callback to Trainer and implement for TrackioCallback
#42850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| import trackio | ||
|
|
||
| trackio_version = packaging.version.parse(trackio.__version__) | ||
| if trackio_version <= packaging.version.parse("0.12.0"): | ||
| return | ||
|
|
||
| space_url = trackio.sync(project, force=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import trackio | |
| trackio_version = packaging.version.parse(trackio.__version__) | |
| if trackio_version <= packaging.version.parse("0.12.0"): | |
| return | |
| space_url = trackio.sync(project, force=True) | |
| trackio_version = packaging.version.parse(self._trackio.__version__) | |
| if trackio_version <= packaging.version.parse("0.12.0"): | |
| return | |
| space_url = self._trackio.sync(project, force=True) |
| import trackio | ||
|
|
||
| trackio_version = packaging.version.parse(trackio.__version__) | ||
| if trackio_version <= packaging.version.parse("0.12.0"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend forcing trackio>=0.12 directly in the callback init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @qgallouedec what do you mean by forcing? In a way that would not break any existing scripts using an older version of Trackio? I could raise a warning here if using an older version of Trackio
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=42850&sha=78874a |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot ! No strong opinion about forcing users to download the latest version of trackio or not.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.