Skip to content

Conversation

@abidlabs
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Comment on lines +1065 to +1071
import trackio

trackio_version = packaging.version.parse(trackio.__version__)
if trackio_version <= packaging.version.parse("0.12.0"):
return

space_url = trackio.sync(project, force=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import trackio
trackio_version = packaging.version.parse(trackio.__version__)
if trackio_version <= packaging.version.parse("0.12.0"):
return
space_url = trackio.sync(project, force=True)
trackio_version = packaging.version.parse(self._trackio.__version__)
if trackio_version <= packaging.version.parse("0.12.0"):
return
space_url = self._trackio.sync(project, force=True)

import trackio

trackio_version = packaging.version.parse(trackio.__version__)
if trackio_version <= packaging.version.parse("0.12.0"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend forcing trackio>=0.12 directly in the callback init

Copy link
Member Author

@abidlabs abidlabs Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qgallouedec what do you mean by forcing? In a way that would not break any existing scripts using an older version of Trackio? I could raise a warning here if using an older version of Trackio

@github-actions
Copy link
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=42850&sha=78874a

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ! No strong opinion about forcing users to download the latest version of trackio or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants