fix tests/models/edgetam_video/test_modeling_edgetam_video.py #42867
+4
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and tests/models/sam2_video/test_modeling_sam2_video.py crash Signed-off-by: Wang, Yi <[email protected]>
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: edgetam_video, sam2_video |
Contributor
Author
|
@SunMarc please help review. |
SunMarc
reviewed
Dec 15, 2025
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Thanks for checking, while this might fix the tests, I'm sure this will probably lead to another issues as . cc @molbap @ArthurZucker
The comment below is probably connected to this issue:
# need to be ignored, as it's a buffer and will not be correctly detected as tied weight _keys_to_ignore_on_load_missing = ["prompt_encoder.shared_embedding.positional_embedding"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and tests/models/sam2_video/test_modeling_sam2_video.py crash
fix crash like
FAILED tests/models/edgetam_video/test_modeling_edgetam_video.py::EdgeTamVideoModelIntegrationTest::test_inference_mask_generation_video_multi_objects_multi_points - AttributeError:
positional_embeddingis not an nn.Parameter