Support Modular (!!) + Configs in check_auto_docstrings#44803
Open
yonigozlan wants to merge 3 commits intohuggingface:mainfrom
Open
Support Modular (!!) + Configs in check_auto_docstrings#44803yonigozlan wants to merge 3 commits intohuggingface:mainfrom
check_auto_docstrings#44803yonigozlan wants to merge 3 commits intohuggingface:mainfrom
Conversation
yonigozlan
force-pushed
the
add-config-suport-check-auto-docstrings
branch
from
25eec1c to
5d253cd
Compare
yonigozlan
requested review from
ArthurZucker,
Cyrilvallez,
vasqu and
zucchini-nlp
and removed request for
ArthurZucker,
Cyrilvallez,
vasqu and
zucchini-nlp
yonigozlan
changed the title
check_auto_docstringscheck_auto_docstrings
yonigozlan
requested review from
ArthurZucker,
Cyrilvallez,
vasqu and
zucchini-nlp
yonigozlan
changed the title
check_auto_docstringscheck_auto_docstrings
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: afmoe, albert, align, bamba, bigbird_pegasus, bit, bitnet, blip, blt, bridgetower, chameleon, chmv2, clap, clip, clvp, cohere |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44803&sha=f071e9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Finally) add support for checking+fixing both generated files and modular files in
check_auto_docstrings.Also
auto_docstringwas recently added to configs, and this PR updatescheck_auto_docstringsto support configs.This means that we shouldn't have PR merged with docstring related errors/warning anymore + inconsistencies between modular and
check_auto_docstringsoverwriting eachother.Cc @zucchini-nlp for configs