Skip to content

🧸 Fix unset tokenizer pad_token #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 22, 2025
Merged

🧸 Fix unset tokenizer pad_token #3290

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d10e864
tokenizer pad token default when not set
LeonEricsson Apr 14, 2025
bdcadaf
nit
LeonEricsson Apr 14, 2025
30fbdf1
docs
LeonEricsson Apr 17, 2025
f2c1345
Merge branch 'main' into tokenizer_pad_token
LeonEricsson Apr 17, 2025
232d976
Merge remote-tracking branch 'upstream/main' into tokenizer_pad_token
LeonEricsson Apr 17, 2025
1bb5da6
Merge branch 'main' into tokenizer_pad_token
qgallouedec Apr 18, 2025
ae21fc6
always check processing class for pad_token
LeonEricsson Apr 18, 2025
7a0cdfe
style
qgallouedec Apr 21, 2025
92209ee
Merge branch 'main' into tokenizer_pad_token
qgallouedec Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions trl/trainer/grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ def __init__(
# Processing class
if processing_class is None:
processing_class = AutoTokenizer.from_pretrained(model.config._name_or_path, padding_side="left")
if processing_class.pad_token is None:
processing_class.pad_token = processing_class.eos_token
Copy link
Contributor Author

@LeonEricsson LeonEricsson Apr 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we warn/inform the user of this default behaviour?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if processing_class.pad_token is None:
processing_class.pad_token = processing_class.eos_token
if processing_class.pad_token is None:
processing_class.pad_token = processing_class.eos_token

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to run this when the processing class is passed, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed. But the more I think about it, the less I like the idea of silently setting the padding token.... even if it's documented.


# Reward functions
if not isinstance(reward_funcs, list):
Expand Down