Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for FSDP2 by (a) bumping the lower bound on
accelerate
and (b) updatingprepare_fsdp()
.The FSDP2 API is still in beta, so we can hold off on merging this if we feel the
accelerate
version is too high to bump right now. The alternative would be to check the accelerate version being used and only allow FSDP2 to be run for versions > 1.6.0In particular,
FULL_STATE_DICT
is not supported in FSDP2 yet, so it is not possible to savetransformers
friendly checkpoints. This is currently being worked on inaccelerate
, so we could hold off until thenA quick test on SFT shows the two FSDP versions are almost identical, modulo grad norms:
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.