Add {% generation %} markers for Cohere2 chat template#5675
Merged
qgallouedec merged 7 commits intomainfrom May 4, 2026
Merged
Add {% generation %} markers for Cohere2 chat template#5675qgallouedec merged 7 commits intomainfrom
{% generation %} markers for Cohere2 chat template#5675qgallouedec merged 7 commits intomainfrom
Conversation
22 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a115d9df13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
merging this with no review: it's been opened for a while an nothing special/potentially breaking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #5471
Note
Medium Risk
Moderate risk because it changes template auto-swapping logic for Cohere2 and adds a new Jinja template that affects how prompts are rendered during SFT/GRPO, which could subtly impact tokenization and loss masking for those models.
Overview
Adds Cohere2 to TRL’s list of recognized chat-template families and introduces
cohere2.jinjaplus a patchedcohere2_training.jinjathat wraps assistant output in{% generation %}/{% endgeneration %}(and moves<|END_OF_TURN_TOKEN|>into role branches) to enable correctassistant_only_lossmasking.Updates
get_training_chat_template()to detect the Cohere2 original template and swap in the new training variant, and extends the chat-template test matrix to cover the Cohere2 tokenizer; docs/README are updated to document Cohere2 support and the patch rationale.Reviewed by Cursor Bugbot for commit 0d9bcc0. Bugbot is set up for automated code reviews on this repo. Configure here.