Revert xfail for MoE LoRA tests now that peft#3602 fixed the autocast dtype bug - #6919
Merged
albertvillanova merged 1 commit intoAug 25, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
Merging this PR as a hotfix: https://github.com/huggingface/trl/actions/runs/32867925767/job/97867656964
|
albertvillanova
deleted the
revert-hotfix-moe-lora-parametrization-dtype
branch
August 25, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the temporary xfail markers added for the MoE LoRA tests, now that the underlying bug has been fixed upstream:
Fix #6914.
Motivation
peft's LoRA parametrization for MoE expert parameters returned bf16 under autocast, whichregister_parametrizationrejects, so the MoE LoRA tests were marked xfail as a temporary hotfix (#6915) to keep CI green. The bug has since been fixed upstream in peft#3602.Solution
Revert the hotfix commit that added the xfail markers, restoring the tests to their normal (non-xfail) state.
Changes
test_dpo_trainer.py,test_grpo_trainer.py,test_kto_trainer.py,test_reward_trainer.py,test_rloo_trainer.pyandtest_sft_trainer.pyVersionandpeftimports fromtest_reward_trainer.pyNote
Low Risk
Test-only change with no production code paths; CI may fail if the environment still uses a peft version without the upstream fix.
Overview
Reverts the temporary xfail markers on MoE + PEFT/LoRA training tests now that peft#3602 fixes the autocast dtype issue that broke
register_parametrization(closes #6914).Affected suites: DPO, GRPO, KTO, Reward, RLOO, and SFT (
test_train_moe_with_peft_config/test_train_moe_peft_modelwhere applicable). Those tests run as normal failures/pass again instead of expected failures on peft dev releases.In
test_reward_trainer.py, drops unusedpackaging.version.Versionand top-levelpeftimports that only served the xfail condition.Reviewed by Cursor Bugbot for commit dec5654. Bugbot is set up for automated code reviews on this repo. Configure here.