Drop the Slack action checkout workaround from the latest release tests - #7183
Open
albertvillanova wants to merge 1 commit into
Open
Drop the Slack action checkout workaround from the latest release tests#7183albertvillanova wants to merge 1 commit into
albertvillanova wants to merge 1 commit into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the extra checkout that the daily latest-release test workflow needed to resolve the local Slack action.
Motivation
tests_latest.ymlchecks out a release branch instead of the branch running the workflow. When the localpost-slackcomposite action was introduced, the release branch in use at the time (v1.10-release) predated it, so./.github/actions/post-slackcould not be resolved and the action had to be checked out separately.That is no longer the case: the workflow now runs against
v1.13-release, which ships the action, and its copy is identical to the one onmain, so the inputs passed by the Slack step still match.Solution
Resolve the action from the workspace, as every other workflow in the repository already does.
Changes
Check out the Slack actionstep and its commentPost to Slackstep at./.github/actions/post-slackNote
Low Risk
CI-only change to how the Slack notification action is resolved; no application or runtime behavior changes.
Overview
Simplifies the daily tests latest release workflow now that
v1.13-releaseincludes the local Slack composite action.Removes the extra
actions/checkoutstep that sparse-checked out.github/actionsfrom the triggering branch, and points Post to Slack at./.github/actions/post-slacklike the rest of the repo’s workflows.Reviewed by Cursor Bugbot for commit d6c27d3. Bugbot is set up for automated code reviews on this repo. Configure here.