Use the canonical id for the tiny GPTNeoX sequence classification model - #7185
Open
albertvillanova wants to merge 1 commit into
Open
Use the canonical id for the tiny GPTNeoX sequence classification model#7185albertvillanova wants to merge 1 commit into
albertvillanova wants to merge 1 commit into
Conversation
`tests/test_chat_template_utils.py` spelled the model `trl-internal-testing/tiny-GptNeoXForSequenceClassification`, while the repository is `trl-internal-testing/tiny-GPTNeoXForSequenceClassification`. The Hub resolves the first with a redirect, so the tests pass either way. `apply_model_revisions` in `tests/conftest.py` looks the model id up by exact string, so a `MODEL_REVISIONS` entry written with the canonical id would not have matched these three call sites: the tests would have loaded the default branch and passed, reporting a tiny model PR as tested when it was not.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_chat_template_utils.pyrefers to the tiny model astrl-internal-testing/tiny-GptNeoXForSequenceClassification, but the repository istrl-internal-testing/tiny-GPTNeoXForSequenceClassification. The Hub resolves the misspelt id with a 307 redirect, so the tests pass either way and nothing has ever failed because of it.Why it matters
apply_model_revisionsintests/conftest.pyinjects the revision only on an exact match:So a
MODEL_REVISIONSentry written with the canonical id would not match these three call sites. The tests would quietly load the default branch instead ofrefs/pr/N, pass, and report a tiny model PR as tested when it was not. One of the three call sites loads the model as well as the tokenizer, so this covers config and weights, not just the chat template.Nothing is affected retroactively:
MODEL_REVISIONShas never carried an entry for this model, and the Hub repo has no PRs.Found while checking which tiny models the revision override can actually reach.
Changes
tiny-GPTNeoXForSequenceClassificationat its three occurrencesIt also matches the line directly above it in the tool-calling list, which already uses
tiny-GPTNeoXForCausalLM.Note
Low Risk
Test-only string fixes with no runtime or production code changes.
Overview
Updates three references in
tests/test_chat_template_utils.pyfromtrl-internal-testing/tiny-GptNeoXForSequenceClassificationto the canonical Hub idtiny-GPTNeoXForSequenceClassification(tokenizer/model load intest_clone_with_sequence_classification_model, plus thegptneox-seqparam in the tool-calling negative test).Tests still pass today because the Hub redirects the old spelling; the fix matters so
apply_model_revisions’ exactMODEL_REVISIONSlookup would applyrefs/pr/Nto these call sites instead of silently loading the default branch.Reviewed by Cursor Bugbot for commit f5d3b46. Bugbot is set up for automated code reviews on this repo. Configure here.