Train the tiny DeepSeek-R1-Distill model in the SFT test - #7187
Open
albertvillanova wants to merge 1 commit into
Open
Train the tiny DeepSeek-R1-Distill model in the SFT test#7187albertvillanova wants to merge 1 commit into
albertvillanova wants to merge 1 commit into
Conversation
`trl-internal-testing/tiny-Qwen2ForCausalLM-R1-Distill` was used in three places, all in `tests/test_chat_template_utils.py`, and all through `AutoTokenizer`. Nothing loaded its config or weights, so #7135 aligned its `vocab_size`, token ids and position limits against fields no test reads. `test_train` is where the other tiny models get that coverage, and it is what gave the FalconMamba alignment in #7139 a real check.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trl-internal-testing/tiny-Qwen2ForCausalLM-R1-Distillis used in three places, all intests/test_chat_template_utils.py, and all throughAutoTokenizer. Nothing in the suite loads its config or weights.That is how #7135 came to align this model's
vocab_size,bos_token_id,eos_token_id,max_position_embeddingsandmax_window_layersagainst fields no test reads. TheMODEL_REVISIONSrun before that merge did fire, since the tokenizer loads are patched too, but it could only confirm the tokenizer and chat template, never the config the PR actually changed.Adding the model to
test_traincloses that:SFTTrainerloads it from the id, so config and weights are read, and a training step runs. It is the same coverage that made the FalconMamba check in #7139 meaningful.Changes
tiny-Qwen2ForCausalLM-R1-Distillto thetest_trainmodel listNote
Low Risk
Test-only change; no production code paths modified.
Overview
Adds
trl-internal-testing/tiny-Qwen2ForCausalLM-R1-Distillto the parametrizedtest_trainmodel list intest_sft_trainer.py, so CI runs the same SFTTrainer smoke test (load config/weights, train one step, assert loss and updated params) for that checkpoint.This closes a coverage gap: the tiny R1-Distill model was only exercised via
AutoTokenizerin chat-template tests, so changes to model config fields were not validated during training.Reviewed by Cursor Bugbot for commit 025787f. Bugbot is set up for automated code reviews on this repo. Configure here.