Traefik, Secrets, and more. #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tradiuz
commented
Jun 11, 2025
Contributor
Author
tradiuz
left a comment
tradiuz
left a comment
There was a problem hiding this comment.
Notes on all the changes.
Contributor
Author
There was a problem hiding this comment.
This just brings it up to more current versions.
Contributor
Author
There was a problem hiding this comment.
Chart bump (you can probably remove my edit to line 3, i just needed something to disambiguate it in rancher's UI)
| [](https://foundryvtt.com/releases/10.303) | ||
| [](https://foundryvtt.com/releases/11.315) | ||
| [](https://foundryvtt.com/releases/12.324) | ||
| [](https://foundryvtt.com/releases/12.343) |
Contributor
Author
There was a problem hiding this comment.
Badges for v12 (final) and v13 (current)
|
|
||
| ```bash | ||
| $ helm install my-release ./incubator/foundry-vtt | ||
| helm install my-release ./incubator/foundry-vtt |
Contributor
Author
There was a problem hiding this comment.
didn't mean to pull this in, but it's an easy enough fix to revert.
Contributor
Author
There was a problem hiding this comment.
A good baseline set of "questions.yaml" for rancher to allow using the UI instead of editing yaml. Will probably need improvement.
| @@ -1,3 +1,4 @@ | |||
| {{- if empty .Values.foundryvtt.configSecretName }} | |||
Contributor
Author
There was a problem hiding this comment.
added new fields for the schema. I think my tab spacing of 2 made it seem like a larger change.
| fullnameOverride: "" | ||
| dnsPolicy: "ClusterFirst" | ||
| dnsConfig: | ||
| {} |
Contributor
Author
There was a problem hiding this comment.
fix to comply with schema
| enabled: false | ||
| size: 5Gi | ||
| ## Specify the name of an existing Persistent Volume Claim | ||
| claimName: "" |
Contributor
Author
There was a problem hiding this comment.
fix to comply with schema
| ## @param foundryvtt.licenseKey License Key for FoundryVTT. If set the account infos are ignored. | ||
| ## @param foundryvtt.existingSecret Name of an existing Secret to fetch the account from. If set, account settings from values are ignored. Must be used in combination with `foundryvtt.existingLicenseType` to fetch the correct data | ||
| ## @param foundryvtt.existingLicenseType Type of License to be fetched from the existing secret. Must be either `account` or `licenseKey`. If set to `account`, the `existingSecret` must contain a `username`/`password` data pair. If set to `licenseKey`, the secret must contain a `licenseKey` data entry | ||
| ## @param foundryvtt.configSecretName Name of an existing Secret to fetch the account from. If set, account settings from values are ignored. Make sure the keys are defined, even if empty. |
Contributor
Author
There was a problem hiding this comment.
existingSecret and existinglicenseType was never used that i could see. collapsed it down into a single secret called configSecretName to have everything.
hugoprudente
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Addresses #51
Fixes #79
Fixes #14
Adds support for felddy's 13.345 container (requires the container context to not be root, which has fs issues)
Fixes the lint action as well.
Adds Questions support for rancher.