Skip to content

Conversation

@radarhere
Copy link

Suggestions for python-pillow#9239

  • Update actions/download-artifact to v5
  • Count dists before uploading scientific wheels or publishing to PyPI. If we suddenly started producing more wheels than expected, maybe we should inspect that before sharing those wheels?
  • At the moment, the printed number of dists and the number of dists checked by the condition are from two different ls operations. I suggest making that the same operation, so the user can be confident in what the output is saying.

@radarhere
Copy link
Author

The iOS arm64 simulator failure is because your fork is using macos-15-arm64. The main repository is still on macos-14-arm64 for the moment, so I expect this to pass if merged.

I find this odd, as we are requesting macos-14.

@hugovk
Copy link
Owner

hugovk commented Oct 11, 2025

The push and pull_request triggers are slightly different.

  • push just runs the commit as it appears in the branch.

  • But pull_request simulates merging the commit into the base, and runs that.

Most of the time, it's the same result. But in cases like this, it fails. And we only have pull_request running here.

I'll update my main from upstream and restart this.

@hugovk
Copy link
Owner

hugovk commented Oct 11, 2025

And the failing run here has:

          - name: "iOS arm64 simulator"
            platform: ios
            os: macos-latest

Whereas upstream has:

          - name: "iOS arm64 simulator"
            platform: ios
            os: macos-14

https://github.com/python-pillow/Pillow/actions/runs/18423923094/workflow#L100

@hugovk
Copy link
Owner

hugovk commented Oct 11, 2025

Let's see if close/re-open triggers it.

@hugovk hugovk closed this Oct 11, 2025
@hugovk hugovk reopened this Oct 11, 2025
@hugovk
Copy link
Owner

hugovk commented Oct 11, 2025

Close/re-open didn't do it: https://github.com/hugovk/Pillow/actions/runs/18427497312/workflow?pr=139#L101

And wow, the rebase on upstream/main didn't help either!

@hugovk
Copy link
Owner

hugovk commented Oct 11, 2025

OK, that wasn't a pretty Git session but we're there now!

Co-authored-by: Hugo van Kemenade <[email protected]>
@radarhere
Copy link
Author

I don't know what's going on with this PR that is causing lint to fail, but I remain confident that the changes would be valid for python-pillow.

Co-authored-by: Andrew Murray <[email protected]>
@hugovk
Copy link
Owner

hugovk commented Oct 11, 2025

I don't know what's going on with this PR that is causing lint to fail, but I remain confident that the changes would be valid for python-pillow.

Yeah, let's just merge and move things back there :)

@hugovk hugovk merged commit bd29f65 into hugovk:count-dists Oct 11, 2025
0 of 3 checks passed
@radarhere radarhere deleted the count-dists branch October 11, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants