-
Notifications
You must be signed in to change notification settings - Fork 18
feat: changesets config and github workflow setup #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @ramu-narasinga , this is looking good. Are you able to fix the comment in my review and I'd be happy to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR sets up the project's automated release flow using changesets with a new GitHub workflow and adds initial documentation for the changesets configuration.
- Introduces .github/workflows/npm-release.yml for automating package version updates and NPM publishing upon PR merge.
- Adds a README file in the .changeset folder to guide users on using changesets in the project.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/npm-release.yml | Implements a workflow for version bumping, publishing to NPM, and handling changesets |
| .changeset/README.md | Provides basic documentation about changesets and links to further info |
Files not reviewed (2)
- .changeset/config.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/npm-release.yml:25
- Using a shallow checkout (fetch-depth: 1) may lead to issues if changeset commands rely on commit history; consider increasing the fetch depth or removing the option to ensure all necessary commit data is available.
fetch-depth: 1
|
Hey @hugs7 I have checked the comment, it is looking good too. I just removed the WIP from the title, please go ahead and merge it. Thanks. |
Tagged you above |
|
Thank you @ramu-narasinga |
|
Thank you @hugs7 |
What this PR is about?
.changesets folder
The overall tool after initialization should lead to a loop that looks like:
Example
I am demonstrating how this will be integrated with your release flow in this example by a series of steps. @hugs7
And this will prompt a few questions and answer them accordingly. This will be about the change you are making and whether it is patch, minor or major in semver versioning.
When you do this, this will add a file in .changesets folder and you should make sure to include this in your commit. This file is used to generate CHANGELOG.md for the releases made for your library.
Please read this documentation for more information
Research:
I pulled the workflows/npm-release.yml related code from https://github.com/Shopify/buy-button-js, did study other workflows but this Shopify release seemed simple and straightforward.
References: