[codex] Improve runtime reliability and validation workflows#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the current runtime reliability and validation workflow work with two targeted resilience fixes:
auto-finishnow survives readonlyuser-cacheasset paths when writing activation feedback back into assets.It also includes a focused validation pass over candidate backlog and unproven assets so the new prior/constraint assets have real help signals, not just stored inventory.
What changed
runtime/cli/main.py_apply_activation_feedback()now returns bothactivation_feedbackand anywrite_warnings.user-cacheoutputs.auto-finishand explicitfeedbackboth surface fallback warnings instead of failing onPermissionError.runtime/storage/milvus_store.pymilvus_lock_summary()now clears stale dead-pid lock metadata when no real flock owner exists.stale_metadata_clearedso doctor/status can distinguish self-healed stale metadata from live locks.tests/test_cli_flow.pyuser-cacheasset writes duringauto-finishfeedback persistence.tests/test_milvus_store.pyWhy
The recent review loop exposed two recurring runtime quality gaps:
Fixing both makes the runtime more robust and makes daily review output more trustworthy.
Validation
python3 -m unittest tests.test_cli_flow.CliFlowTests.test_cli_auto_finish_falls_back_when_feedback_asset_write_hits_primary_user_cache_root tests.test_cli_flow.CliFlowTests.test_cli_auto_finish_falls_back_when_primary_memory_root_is_unwritable tests.test_cli_flow.CliFlowTests.test_cli_auto_finish_records_activation_help_feedback_for_later_runs tests.test_cli_flow.CliFlowTests.test_cli_auto_finish_persists_asset_effectiveness_summarypython3 -m unittest tests.test_milvus_store.MilvusStoreLockTestsEXPCAP_STORAGE_PROFILE=user-cache EXPCAP_HOME=$HOME/.expcap scripts/expcap doctor --workspace "$PWD"Runtime impact
candidate_review_queue has 20 pending items.