Switch release workflow to manual dispatch with version input - #16
Draft
roborourke wants to merge 2 commits into
Draft
Switch release workflow to manual dispatch with version input#16roborourke wants to merge 2 commits into
roborourke wants to merge 2 commits into
Conversation
Replace the release-created trigger (which required retagging and a force push to inject the built/version-bumped commit into the tag) with a workflow_dispatch trigger that takes a version number input. The tag is now created fresh from the version-bumped commit, so no force push is needed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0195K19h2qMkAjp6iWVghaTc
Playwright E2E Test Results (PHP 8.4, WP 6.9)Details
Flaky testschromium › persist-success.spec.js › HubSpot Form — persist success › should show full inline message including first-submission group on fresh success |
Collaborator
Author
|
The
This is the live-HubSpot-SDK timing sensitivity called out in Generated by Claude Code |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0195K19h2qMkAjp6iWVghaTc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
release: createdtrigger inrelease.ymlwith a manualworkflow_dispatchtrigger that takes a version number input, mirroring the change we made to thehm-query-loopplugin.Why
The previous workflow required creating a GitHub Release first (which creates the tag), then the workflow would substitute
__VERSION__, build, retag withgit tag -f, andgit push --forceto move the tag onto the version-bumped/built commit. Force-pushing tags is fragile and rewrites tag history.What changed
release: created→workflow_dispatchwith a requiredversionstring input (e.g.1.2.3, no leadingv).v{version}tag fresh from the version-bumped commit, so there's nothing to retag or force-push.npm i→ substitute__VERSION__with the input version →npm run build→ commit + create/pushv{version}tag →npm run plugin-zip→gh release createwithhubspot-form-block.zipattached and auto-generated notes.CLAUDE.mdto document the new manual process.How to release now
Run the Version and Release workflow from the Actions tab, entering the version number. The tag and GitHub Release are created by the workflow.
🤖 Generated with Claude Code
https://claude.ai/code/session_0195K19h2qMkAjp6iWVghaTc
Generated by Claude Code