Skip to content

Add Apple Sign-In #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shomykohai wants to merge 1 commit into
base: the-future
Choose a base branch
from
Open

Add Apple Sign-In #1502

shomykohai wants to merge 1 commit into from

Conversation

@shomykohai
Copy link
Contributor

@shomykohai shomykohai commented Apr 2, 2024

What

This PR aims to add Sign-In with Apple support to Kitsu.
Supersedes #1291.

  • Adds Apple Sign-In to doorkeeper assertions.
  • Adds Apple as an external identity provider in GraphQL
  • Add apple_id to the DB's user table

Checklist

  • All files pass Rubocop
  • Any complex logic is commented
  • Any new systems have thorough documentation
  • Any user-facing changes are behind a feature flag (or: explain why they can't be)
  • All the tests pass
  • Tests have been added to cover the new code

hound[bot]
hound bot reviewed Apr 2, 2024
View reviewed changes
@shomykohai shomykohai mentioned this pull request Apr 2, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hound hound[bot] hound[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shomykohai