Skip to content

Conversation

@gglucass
Copy link

@gglucass gglucass commented Nov 6, 2025

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Fixes #548

Adds robustness in the case a Uniswap V2 deployment is not present on a chain.

Tests performed by the developer:
Swapping on Celo didn't work at first, now it does.

Tips for QA testing:
Swap USDGLO for USDC on Celo using current version which should fail, and this version which should succeed.

@gglucass gglucass changed the title Check if a V2 deployment is present. If not, proceed with V3. Fixes https://github.com/hummingbot/gateway/issues/548 Check if a V2 deployment is present. If not, proceed with V3. Fixes #548 Nov 10, 2025
@rapcmia rapcmia moved this to Backlog in Pull Request Board Nov 10, 2025
@rapcmia rapcmia self-requested a review November 10, 2025 16:14
@fengtality
Copy link
Contributor

@gglucass See comment in issue #548

@gglucass
Copy link
Author

gglucass commented Nov 12, 2025

@fengtality - responded in #548 . Note that this PR is to prevent uniswap/router swaps from failing in the event the chain has no UniswapV2 deployment, which is the case for Celo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Discussion

Development

Successfully merging this pull request may close these issues.

3 participants