Add support for custom torrc configurations#9
Open
pluja wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, first off, thank you for maintaining this great project!
I needed to use some custom configurations in the torrc, and I thought it would be nice to have an option to directly configure it via environment variables, so I made a few changes to the entrypoint script to implement that. I also made a few other small changes to the script (added functions, etc), please do check it and test it (I have tested it myself, and it works fine for me).
Basically, new env variables are accepted with the format
TORRC_[CONFIG](for globally applied torrc options) orTORRC_[SERVICE_NAME]_[CONFIG]for service-specific configurations. Here's an example:This would apply the first two configurations globally, and the last two to their respective services.
Tell me if you want me to change anything or any question. Feel free to close the PR if it's out of the scope of the project!