chore: migrate to Vitest 5 and align Vite 8 catalog - #2872
maxffarrell wants to merge 3 commits into
Conversation
|
There was a problem hiding this comment.
🟢 Approval recommended
The changes are a consistent dependency/version alignment (Vitest/Vite/Node engines) with corresponding lockfile updates and no indicated source-level behavior changes required.
Pull request overview
This PR upgrades the monorepo’s testing setup to Vitest 5 and refreshes the pnpm workspace dependency catalog to match the Vite/Svelte tooling versions already used by the docs, along with a lockfile regeneration reflecting the new dependency graph.
Changes:
- Bump Vitest from
^4.1.10to^5.0.0in the two workspaces that run tests (CLI + registry). - Update the pnpm workspace catalog to Vite
^8.1.5and@sveltejs/vite-plugin-svelte^7.2.0. - Update the root
engines.nodeconstraint to match Vitest 5’s supported Node range and regeneratepnpm-lock.yaml.
File summaries
| File | Description |
|---|---|
| sv-addons/registry/package.json | Updates the registry workspace test runner to Vitest 5. |
| packages/cli/package.json | Updates the CLI workspace test runner to Vitest 5. |
| pnpm-workspace.yaml | Aligns catalog versions for Vite and Svelte’s Vite plugin with current tooling. |
| package.json | Raises the monorepo root Node engine range to match Vitest 5 requirements. |
| pnpm-lock.yaml | Regenerated lockfile reflecting Vitest 5 and related transitive updates. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Upgrade both test packages from Vitest 4.1.10 to 5.0.0 and regenerate the lockfile. Align the stale workspace catalog with Vite 8.1.5 and Svelte Vite plugin 7.2.0, which the docs already use, and require a Node version supported by Vitest 5 at the private monorepo root.
Reviewed the official Vitest 5 migration guide, the preceding Vitest 4 guide, and the Vite migration guide. Current upstream already uses Vitest 4 and Vite 8; no test or application source changes are required. Published CLI runtime requirements are unchanged.
Validation on Node 26.8.1 / pnpm 10.32.1:
CI=true pnpm test: 260 tests passed across 23 files, including generated registry fixtures and CLI snapshots.pnpm lint: passed.pnpm check: passed, zero Svelte errors or warnings.CI=true pnpm build:docs: passed, including Cloudflare adapter output.pnpm install --frozen-lockfile --ignore-scripts --offline: passed.