feat: enable gas usage data#27
Open
crash0verride11 wants to merge 8 commits into
Open
Conversation
Adds support for gas meters that report DAILY usage. Will revise to pull intervalType and periodType from Duke or have the user configure on setup.
Updated installation instructions and add Safari extension support.
roll back readme for cleaner pull
* add gas to supported meter types * added tuple to pass interval to statistics entry and switched serviceType statistic check to be interval based (correct logic for future interval selection)
Adjust comment to reflect altered code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to commit the features I spent time deciphering the API for and also want to throw my hat in the ring that noon is the true and only answer for when to log data!, so opening my own competing pull. At start and end of day some data is theoretically skewer 23 hours at noon the most it is skewed is 12 hours.
Interval / period for gas usage
Recent discussion made me go back to the Duke Energy app and see how it gates whether or not to show the hourly usage / 'yesterday' pane. The actual app code gates this at the UI level (looking through a decompiled android APK), so I'm now pretty confident that the Duke Energy app API only checks DAILY for gas meters, If not the next most likely option is it's gated by region and users will chime in, but the app code, again, indicated this isn't true. As a result I don't think a configuration step is warranted after all.
Changes