Skip to content

Fix: Prevent infinite recursion when closing streamable sessions #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshuasundance-swca wants to merge 2 commits into from
Closed

Fix: Prevent infinite recursion when closing streamable sessions #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f653e3
Fix: Prevent infinite recursion when closing streamable sessions
joshuasundance-swca Sep 11, 2025
39d056a
guard against memory leak
joshuasundance-swca Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions src/services/streamable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,20 +77,31 @@ export const startHTTPStreamableServer = async (
});

// Handle the server close event.
let isTransportClosed = false;
let isServerClosed = false;

transport.onclose = async () => {
if (isTransportClosed) {
Logger.warn("Transport already closed, skipping onclose handler to avoid infinite recursion");
return; // Prevent re-entrancy
};

isTransportClosed = true;

const sid = transport.sessionId;
if (sid && activeTransports[sid]) {
try {
await server?.close();
} catch (error) {
Logger.error("Error closing server", error);
// Optionally close the server, but guard against recursion
if (!isServerClosed) {
try {
await server.close();
isServerClosed = true;
} catch (error) {
Logger.error("Error closing server", error);
}
}

// delete used transport and server to avoid memory leak.
delete activeTransports[sid];
}
};

// Create the server
try {
server = createServer();
Expand Down