Skip to content

refactor: standardize default pool size usage in SapConnectionPool #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucaAstolfi88 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: standardize default pool size usage in SapConnectionPool #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7647cce
Merge tag '1.6.4' into develop
huysentruitw Sep 9, 2025
026dfbd
refactor: standardize default pool size usage in SapConnectionPool
MegaLucazzo Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/SapNwRfc/Pooling/SapConnectionPool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace SapNwRfc.Pooling
/// </summary>
public sealed class SapConnectionPool : ISapConnectionPool
{
public const int DefaultPoolSize = 5;
private readonly SapConnectionParameters _connectionParameters;
private readonly int _poolSize;
private readonly Func<SapConnectionParameters, ISapConnection> _connectionFactory;
Expand All @@ -30,7 +31,7 @@ public sealed class SapConnectionPool : ISapConnectionPool
[SuppressMessage("ReSharper", "RedundantOverload.Global", Justification = "Public constructor should not expose connection factory")]
public SapConnectionPool(
string connectionString,
int poolSize = 5,
int poolSize = DefaultPoolSize,
TimeSpan? connectionIdleTimeout = null,
TimeSpan? idleDetectionInterval = null)
: this(SapConnectionParameters.Parse(connectionString), poolSize, connectionIdleTimeout, idleDetectionInterval, null)
Expand All @@ -47,7 +48,7 @@ public SapConnectionPool(
[ExcludeFromCodeCoverage]
public SapConnectionPool(
SapConnectionParameters connectionParameters,
int poolSize = 5,
int poolSize = DefaultPoolSize,
TimeSpan? connectionIdleTimeout = null,
TimeSpan? idleDetectionInterval = null)
: this(connectionParameters, poolSize, connectionIdleTimeout, idleDetectionInterval, null)
Expand All @@ -56,13 +57,15 @@ public SapConnectionPool(

internal SapConnectionPool(
SapConnectionParameters connectionParameters,
int poolSize = 5,
int poolSize = DefaultPoolSize,
TimeSpan? connectionIdleTimeout = null,
TimeSpan? idleDetectionInterval = null,
Func<SapConnectionParameters, ISapConnection> connectionFactory = null)
{
_connectionParameters = connectionParameters;
_poolSize = poolSize;
/* fallback to connection string if pool size not specified*/
var poolSizeFromConnectionString = int.TryParse(_connectionParameters.PoolSize ?? _connectionParameters.MaxPoolSize ?? "0", out int parsedPoolSize) ? parsedPoolSize : 0;
_poolSize = poolSize != DefaultPoolSize && poolSizeFromConnectionString == 0 ? poolSize : poolSizeFromConnectionString;
_connectionIdleTimeout = connectionIdleTimeout ?? TimeSpan.FromSeconds(30);
_connectionFactory = connectionFactory ?? (parameters => new SapConnection(parameters));
_leases = new SemaphoreSlim(poolSize, poolSize);
Expand Down