Skip to content

feat: add support for extension 'biomejs.biome' - #133

Closed
blixt wants to merge 1 commit into
hverlin:mainfrom
blixt:feat/add-biome
Closed

feat: add support for extension 'biomejs.biome'#133
blixt wants to merge 1 commit into
hverlin:mainfrom
blixt:feat/add-biome

Conversation

@blixt

@blixt blixt commented Jul 20, 2025

Copy link
Copy Markdown

Adds support for the Biome extension config.

Comment thread src/utils/supportedExtensions.ts
@hverlin

hverlin commented Jul 21, 2025

Copy link
Copy Markdown
Owner

Won't this cause an issue if you have biome installed globally but also added to your node_modules in a particular project?

Based on the code here, it appears that biome will always prefer the version that is set in the settings over the version that is set in the node_modules: https://github.com/biomejs/biome-vscode/blob/ff0730ec7d70d82b4ebcb51c2a5146e7ffd2268b/src/locator.ts#L123-L132

image

Which it is handy to have biome available globally in projects where there are no node_modules, I feel like the most common use case is to install it with npm, pnpm, yarn, etc.

What do you think? Either biome VS Code needs to add some logic to make the resolution order configurable, or we can add some logic to prefer node_modules/.bin/biome if available. The last option is to not merge it and let the user configure the extension manually. (Also note that if biome is on your PATH - should be the case with mise, the extension will use it if not found in node_modules)

@blixt

blixt commented Jul 21, 2025

Copy link
Copy Markdown
Author

So my reasoning for wanting shared workspace support for Biome was that in our repo, we had trouble with a node_modules-based Biome because our monorepo was not TypeScript-first (i.e. Biome was living in a deeper directory, but we still wanted to use it to format top-level JSON files, etc).

If you think it's better to manage Biome via node_modules entirely, then we can indeed close this, though it implies the only way for us to get everything to work "out of the box" (which is why we use mise) would be to convert the monorepo to having a top-level package.json for the workspace, which maybe isn't such a bad thing.

@jonahmdot

Copy link
Copy Markdown

Any updates on this? We had similar issues with Biome installed in a node_modules that wasn't in the root of our workspace.

Since we need formatters and linters for multiple languages, I personally find it much better to manage them all with mise.

@hverlin

hverlin commented Oct 12, 2025

Copy link
Copy Markdown
Owner

What I can suggest is to add biome to the ignore list by default https://hverlin.github.io/mise-vscode/reference/settings/#miseconfigureextensionsautomaticallyignorelist ?

@hverlin

hverlin commented Oct 13, 2025

Copy link
Copy Markdown
Owner

closing as I added it in fadf28d

Note that automatic configuration of biome is disabled by default (see why here #133 (comment)), but you can enable it by overriding the default ignore list

"mise.configureExtensionsAutomaticallyIgnoreList": [],

@hverlin hverlin closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants