fix: handle //:name depends without crashing task graph - #274
Merged
Conversation
`//:name` refers to a task at the monorepo root config root, so the `pathPattern` between `//` and `:` is empty. `dependsPatternMatchesTask` short-circuits when that empty string exactly matches a root target's config root, but for a target in a non-root config root it fell through to `micromatch.isMatch(targetConfigRoot, "", ...)`, which picomatch rejects with `Expected pattern to be a non-empty string`. That path is hit for every non-root task while building the task graph, so a single `//:name` depends entry took the whole graph webview down. Skip the micromatch call for an empty pathPattern (the exact-match branch already yields the correct answer for root-only targets), and guard `matchesTaskName` against empty patterns defensively so any other edge case that leaks an empty pattern returns `false` instead of throwing. Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//:namerefers to a task at the monorepo root config root, so thepathPatternbetween//and:is empty.dependsPatternMatchesTaskshort-circuits when that empty string exactly matches a root target's config root, but for a target in a non-root config root it fell through tomicromatch.isMatch(targetConfigRoot, "", ...), which picomatch rejects withExpected pattern to be a non-empty string. That path is hit for every non-root task while building the task graph, so a single//:namedepends entry took the whole graph webview down.Skip the micromatch call for an empty pathPattern (the exact-match branch already yields the correct answer for root-only targets), and guard
matchesTaskNameagainst empty patterns defensively so any other edge case that leaks an empty pattern returnsfalseinstead of throwing.