fix: prevent Django admin dark mode from breaking editor text color#325
Open
gghez wants to merge 1 commit into
Open
fix: prevent Django admin dark mode from breaking editor text color#325gghez wants to merge 1 commit into
gghez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color: whiteon body cascades into the CKEditor content area, making text invisible (white on white).colorandbackgroundon.ck-contentusing CKEditor's own CSS variables (--ck-color-textand--ck-color-base-background), breaking the inheritance chain.CKEDITOR_5_CUSTOM_CSSstill work — they override the same variables.Closes #305
Test plan
prefers-color-scheme: dark— editor text should be dark on white backgroundCKEDITOR_5_CUSTOM_CSSwith dark CKEditor variables — editor should render with custom dark theme