fix: Deny passing Buffer columns to SQLite JSON helpers#1
Draft
fix: Deny passing Buffer columns to SQLite JSON helpers#1
Conversation
ba508a8 to
beb2b3b
Compare
5b1abd5 to
4babce7
Compare
- Added HasUint8Array<T> and ObjectHasUint8ArrayProperty<O> type utilities - SQLite JSON helpers now return KyselyTypeError when binary columns are detected - Error message includes workarounds: eb.cast<string>(column, "text") or sql<string>`hex(column)`
3b148d7 to
d61611b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howdy 🖖,
This PR adds compile-time type checks to SQLite JSON helpers (
jsonArrayFrom,jsonObjectFrom,jsonBuildObject) to rejectBuffer/Uint8Arraycolumns.Passing binary values to JSON functions throws
SqliteError: JSON cannot hold BLOB values. This change prevents that runtime error by catching it at compile time.Changes
Added
HasUint8Array<T>andObjectHasUint8ArrayProperty<O>type utilitiesSQLite JSON helpers now return
KyselyTypeErrorwhen binary columns are detectedError message includes workarounds:
eb.cast(column, "text")orsql`hex(column)`Example